Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub issue links in IDEA Git log #2241

Merged
merged 3 commits into from
Apr 17, 2020
Merged

GitHub issue links in IDEA Git log #2241

merged 3 commits into from
Apr 17, 2020

Conversation

turansky
Copy link
Contributor

@turansky turansky commented Apr 5, 2020

Overview

GitHub issue links in IDEA Git log

Definition of Done

Clickable links in IDEA Git log

Before - #2236
After - #2236

Screenshot 2020-04-05 at 16 26 37

@sbrannen sbrannen added this to the 5.7 M1 milestone Apr 5, 2020
@sbrannen
Copy link
Member

sbrannen commented Apr 5, 2020

Tentatively slated for 5.7 M1 for team discussion

@codecov
Copy link

codecov bot commented Apr 5, 2020 •
edited
Loading

Codecov Report

Merging #2241 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2241   +/-   ##
=========================================
  Coverage     91.19%   91.19%           
  Complexity     4463     4463           
=========================================
  Files           383      383           
  Lines         10727    10727           
  Branches        869      869           
=========================================
+ Hits           9782     9783    +1     
  Misses          728      728           
+ Partials        217      216    -1
Impacted Files Coverage Δ Complexity Δ
...jupiter/engine/execution/ExtensionValuesStore.java 91.17% <0.00%> (+1.47%) 21.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdf362...e225dc7. Read the comment docs.

@vlsi vlsi mentioned this pull request Apr 5, 2020
Closed
@marcphilipp
Copy link
Member

Team decision: Since this saves time for all maintainers/contributors using IntelliJ IDEA, we have decided to merge this PR, even though it's IDE-specific configuration.

@marcphilipp marcphilipp merged commit 707db08 into junit-team:master Apr 17, 2020
@marcphilipp marcphilipp mentioned this pull request Apr 17, 2020
Merged
@marcphilipp
Copy link
Member

@turansky Thanks for the PR! 👍

@Bukama Bukama mentioned this pull request Apr 17, 2020
Closed
@nipafx nipafx mentioned this pull request May 4, 2020
Closed
@vlsi vlsi mentioned this pull request May 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: team discussion type: enhancement
Projects
None yet
Milestone
5.7 M1
Development

Successfully merging this pull request may close these issues.
3 participants
@turansky @sbrannen @marcphilipp