Add icon for JetBrains Toolbox #2240
Conversation
.gitignore
Outdated
| @@ -18,7 +18,8 @@ gradle-app.setting | |||
| *.ipr | |||
| *.iws | |||
| *.uml | |||
| .idea/ | |||
| .idea/* | |||
There was a problem hiding this comment.
Why * is added here? It should work without the star.
There was a problem hiding this comment.
Otherwise IntelliJ IDEA doesn't resolve next instruction !.idea/icon.png and show similar warning:
There was a problem hiding this comment.
I agree with @vlsi. If you add the asterisk *, commands like git status -s -u will show you numerous other files under .idea folders across the repo.
There was a problem hiding this comment.
@sbrannen , I'm afraid you are not quite right.
git status -s -u does not show extra files in .idea folder.
I've just opened gitignore documentation, and the star is indeed a way to go: https://git-scm.com/docs/gitignore
/foo/*
!/foo/bar
There was a problem hiding this comment.
Hmmm..... strange... on my machine, git status -s -u was showing me numerous other files after applying this PR.
There was a problem hiding this comment.
TBH, I don't actively use IDEA, but I obviously imported some projects into IDEA at some point, and that's simply what's in the file system.
In any case, isn't is possible to craft the patterns so that they apply to .idea directories in subdirectories as well?
There was a problem hiding this comment.
I obviously imported some projects into IDEA at some point, and that's simply what's in the file system.
In this case IDEA will download Gradle for you (possibly incompatible with your root project) and root project settings will not be applied to your subproject.
For example documentation isn't separate project.
In any case, isn't is possible to craft the patterns so that they apply to .idea directories in subdirectories as well?
I guess not
There was a problem hiding this comment.
Technically speaking, the following would ignore .idea everywhere, except it would keep /.idea/icon.png.
**/.idea/*
!/.idea/icon.png
Of course, it is up to you, however, I'm inclined that .idea from sub-folders should be removed.
There was a problem hiding this comment.
I'd personally rather go with the more explicit (and IMO correct) patterns.
Whether or not somebody has .idea folders in subfolders is up to that individual. Maybe it's an accident, but maybe it's intentional.
@junit-team/junit-lambda Thoughts?
There was a problem hiding this comment.
I'd personally rather go with the more explicit (and IMO correct) patterns.
@sbrannen Done :)
Codecov Report
@@ Coverage Diff @@
## master #2240 +/- ##
============================================
+ Coverage 91.17% 91.19% +0.02%
+ Complexity 4489 4463 -26
============================================
Files 386 383 -3
Lines 10773 10727 -46
Branches 874 869 -5
============================================
- Hits 9822 9783 -39
+ Misses 731 728 -3
+ Partials 220 216 -4
Continue to review full report at Codecov.
|
|
Tentatively slated for 5.7 M1 for team discussion |
Co-Authored-By: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
|
Team decision: We decided against adding IDE-specific configuration files. |
|
Team decision: Since we've now merged #2241, we've reconsidered and will accept this one as well. |
|
|
|
Great. Thanks a lot :) 🎉 |
|
Hoped that the default "Welcome to IntelliJ IDEA" screen picked up the icon as well. Apparently, it does not:
Is there already an issue at https://youtrack.jetbrains.com/issues/IDEA to display icons here as well? |
|
@turansky Thanks for the PR! 👍 |
|
@sormuras Mine does:
|
|
@sormuras |
Voted: 👍 |
|
A switch to "IntelliJ Light" and back to black helped.
|
|
It helps till IDEA restart |
Overview
Add icon for JetBrains Toolbox
Definition of Done
Icon is shown in JetBrains Toolbox