Skip to content

Commit

Permalink
Adopt public static Optional<? extends FilePosition> fromQuery in parent
Browse files Browse the repository at this point in the history
  • Loading branch information
Tim te Beek committed Apr 10, 2020
1 parent fb9cec7 commit decb669
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public static FilePosition from(int line, int column) {
* @see #from(int)
* @see #from(int, int)
*/
public static Optional<FilePosition> fromQuery(String query) {
public static Optional<? extends FilePosition> fromQuery(String query) {
FilePosition result = null;
Integer line = null;
Integer column = null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public static FilePosition from(int line, int column) {
* @see #from(int)
* @see #from(int, int)
*/
public static Optional<org.junit.platform.engine.discovery.FilePosition> fromQuery(String query) {
public static Optional<FilePosition> fromQuery(String query) {
FilePosition result = null;
Integer line = null;
Integer column = null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ void filePositionFromLineAndColumn() {
@ParameterizedTest
@MethodSource
void filePositionFromQuery(String query, int expectedLine, int expectedColumn) {
Optional<FilePosition> optionalFilePosition = FilePosition.fromQuery(query);
Optional<? extends FilePosition> optionalFilePosition = FilePosition.fromQuery(query);

if (optionalFilePosition.isPresent()) {
FilePosition filePosition = optionalFilePosition.get();
Expand Down

0 comments on commit decb669

Please sign in to comment.