-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup DDEV homeadditions in entrypoint.sh #10
Conversation
Hi @Biont, Thanks for the PR. Is there any reason not to use a volume for such a purpose? Something like the following in a services:
playwright:
volumes:
- /some/path/on/your/host/to/.npmrc:/home/pwuser/.npmrc |
Yes I think this is something I should explore first. Frankly, I now wonder why this didn't occur to me before I considered the entrypoint script. |
@julienloizelet I thought about this some more. I do think there's value in making the container behave similar to the main DDEV DDEV itself actually just grabs the entire folder and copies it into the local home directory |
@Biont , I am already using a services:
playwright:
environment:
- PLAYWRIGHT_TEST_DIR=your/playwright/directory/path That's why I was suggesting to do the same to handle project specificity. But why not, do you mean we could copy the entire |
Just a note that |
@julienloizelet I updated the PR so it sets up the entire homeadditions folder. @rfay thanks for stopping by. While I have your attention, do you see any downsides to this approach? |
If you're asking whether you can copy ~/.ddev/homeadditions into a separate container, I know of no reason that should be a problem; it will be best if the container is Debian/Ubuntu. |
Merged. I guess I will add something in the README (maybe just to explain how to use a Thanks again. |
Since playwright lives in a separate container, it does not benefit from all the homeadditions-magic that DDEV pours into the
web
-container.This means that if you have some private NPM registries configured (and use private modules for tests), they are not automatically picked up by
ddev playwright-install
, resulting in errors during installation.Luckily, we have access to
/mnt/ddev_config
, which still lets us access it.This PR copies the existing
homeadditions
folder into/home/pwuser
so that they are readable by thepwuser
that installs playwright