Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Install the same version of NodeJS that is specified in .tool-versions #253

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jun 19, 2024

Advantages of this approach:

  1. This ensures that local users (using asdf) will have the same NodeJS version that is used in CI.
  2. Instead of needing to repeat the same version number (20) in multiple CI workflow files, we only need to specify it in a single place.

@DilumAluthge DilumAluthge force-pushed the dpa/release-instructions branch from a6f5baf to 41c27a3 Compare June 19, 2024 22:31
@DilumAluthge DilumAluthge changed the base branch from dpa/release-instructions to master June 19, 2024 22:40
@DilumAluthge DilumAluthge force-pushed the dpa/asdf-node branch 2 times, most recently from 49cf46e to 065c4cb Compare June 19, 2024 22:43
@DilumAluthge DilumAluthge marked this pull request as ready for review June 19, 2024 22:44
@DilumAluthge DilumAluthge requested a review from a team as a code owner June 19, 2024 22:44
@DilumAluthge DilumAluthge enabled auto-merge (squash) June 19, 2024 23:07
@DilumAluthge DilumAluthge disabled auto-merge June 19, 2024 23:08
@DilumAluthge DilumAluthge merged commit 42e03d3 into master Jun 19, 2024
49 checks passed
@DilumAluthge DilumAluthge deleted the dpa/asdf-node branch June 19, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant