This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Detect the default interface #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Readme 👮 wants more details about what this does |
|
🏆 This is a great fix up for #16 I'm over-all really happy with this proposal. One thing I would like to suggest is to put in the status-history which interface it auto-selected so the user has an opportunity to find what interface it picked without remoting into each unit. juju status-history kubernetes/0 would be good info to have, but its not super critical that go in this merge. Just food for thought for future iterations. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With xenial the interface is
ens4the code was expectingeth0and the assumption breaks the configuration of the flannel interface.Changed the default behavior to attempt to detect the default interface when the
ifaceconfiguration option is None or "".Take that !
edit: closes #16