[ENH]: Unix path expansion directives support for PatternDataGrabber
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synchon
added
enhancement
|
Needs to go before #344 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
3 tasks
fraimondo
requested changes
May 22, 2024
synchon
force-pushed
the
feat/unix-path-expansion-pattern-dg
branch
from
3bbf98b to
80a5a4a
Compare
fraimondo
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying Unix path expansion directives like
[], [!]forPatternDataGrabberpatterns. This is an improvement which is needed for supportingFreeSurferdata type. For example,fsaveragedirectory is at the same level as subjects likesub-0001for AOMIC datasets and[!f]allows to not glob thefsaveragedirectory without overridingget_elements()method. As the.mgzand other outputs ofFreeSurferare not unique by subject (and/or task / session) prefix, globbing doesn't work as usual (at least for the AOMIC datasets). This also enables one to have the pattern:.../T1.mg[z]to make it work.