Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH]: Allow BOLDWarper to warp between MNI spaces #302

Merged
merged 10 commits into from
Feb 21, 2024
Merged

[ENH]: Allow BOLDWarper to warp between MNI spaces #302

merged 10 commits into from
Feb 21, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Feb 8, 2024 •
edited
Loading

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR allows BOLDWarper to warp BOLD data to other MNI spaces like MNI152Lin, MNI152NLin2009cAsym, MNI152NLin6Asym and others.

@synchon synchon added the preprocess Issues or pull requests related to preprocessors label Feb 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-21 14:52 UTC

@synchon synchon requested a review from fraimondo February 8, 2024 14:22
@codecov Codecov
Copy link

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (03d5e91) 89.15% compared to head (37a68eb) 88.79%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   89.15%   88.79%   -0.37%     
==========================================
  Files         101      101              
  Lines        4483     4506      +23     
  Branches      856      860       +4     
==========================================
+ Hits         3997     4001       +4     
- Misses        348      366      +18     
- Partials      138      139       +1
Flag Coverage Δ
junifer 88.79% <15.78%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/preprocess/bold_warper.py 38.88% <15.78%> (-15.95%) ⬇️

@synchon synchon added this to the 0.0.4 (alpha 3) milestone Feb 8, 2024
@synchon synchon force-pushed the update/multi-mni-bold-warper branch from bb0b512 to 1bbe60b Compare February 9, 2024 11:01
fraimondo
fraimondo requested changes Feb 14, 2024
View reviewed changes
junifer/preprocess/bold_warper.py Outdated Show resolved Hide resolved
junifer/preprocess/bold_warper.py Outdated Show resolved Hide resolved
@synchon synchon requested a review from fraimondo February 16, 2024 14:20
@synchon synchon requested a review from fraimondo February 21, 2024 13:01
@synchon synchon merged commit 9316bca into main Feb 21, 2024
17 of 20 checks passed
@synchon synchon deleted the update/multi-mni-bold-warper branch February 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fraimondo fraimondo fraimondo approved these changes

Assignees
No one assigned
Labels
preprocess Issues or pull requests related to preprocessors
Projects
None yet
Milestone
0.0.4 (alpha 3)
Development

Successfully merging this pull request may close these issues.
2 participants
@synchon @fraimondo