This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Add private field to access declared types #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspahrsummers
suggested changes
Feb 19, 2020
There was a problem hiding this comment.
Thanks for the pull request! I'm happy to add this as a private API, but would like it to be implemented a little differently for landing.
Instead of attempting to access certain attributes and catch any exception that results, can you extend the TupleConstructor and IdentityConstructor types so they all have one method/property which you can consistently invoke from this code?
Once the exception handling is gone, this can also be nicely rewritten as a list comprehension. 😄
SebastienLavoie
force-pushed
the
expose-declared-types
branch
from
fc04252 to
c4bb581
Compare
|
Thank you for the quick response and the feedback! I hope these changes are what you wanted. It does make for much cleaner code 😃 |
|
Very sorry for the delayed review, and thank you for the updates! This looks great. 🌟 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a way to fetch the types that were declared in the
Case[...]. If there is a better way of doing this, please let me know!