This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Small improvements #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchresta
force-pushed
the
small_improvements
branch
from
d2f986b to
6e7c8bc
Compare
* Add a small test to check if code in example is executable * tests directory contains files that will not type-check deactivate type-checker for imports in tests/
* Add test cases for issues jspahrsummers#21, jspahrsummers#25, jspahrsummers#26 * Test case for jspahrsummers#21 is active because it passes with mypy==0.711 * Test cases for jspahrsummers#25 and jspahrsummers#26 are deactivated because they fail
wchresta
force-pushed
the
small_improvements
branch
from
6e7c8bc to
6c16d02
Compare
jspahrsummers
added a commit
that referenced
this pull request
Dec 28, 2019
|
Thank you, this pull request is incredible! 🌟 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request contains three small improvements:
While testing I found some issues with the mypy plugin. I created the test cases but deactivated them.
The unit test for the README code could probably be refactored into re-using the code in the README. I'm probably not going to get to it for a while, so I might just remove the README unit-test if you consider this to be a blocker. We can add it later when I (or someone else) has time.
If you don't like the idea of the issue-style unit-tests, I can create a merge request just for the README fix, instead.