Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 5.2.9 #591

Merged
merged 5 commits into from
Sep 25, 2019
Merged

Backports for 5.2.9 #591

merged 5 commits into from
Sep 25, 2019

Conversation

erayd
Copy link
Contributor

@erayd erayd commented Sep 25, 2019

Bugfixes from 6.0.0 that can be backported to 5.2.9 without breaking backwards-compatibility.

Backported PRs

Additional PRs (5.x.x only)

These PRs are only applicable to the 5.x.x branch, and have been merged individually.

Skipped PRs

Bruce Chase and others added 5 commits September 26, 2019 02:31
Tests number, integer and string array items
types that have enums of acceptable values
Validation tests for an undefined instance should be limited to those
tests which are actually applicable (e.g. required, default). Tests
which assume an instance previously attempted to validate an internal
default when the instance is undefined, rather than ignoring it, which
is incorrect behavior.

Closes jsonrainbow#566.
* Tests on php 7.3
* bumping php-cs-fixer version as per comment from @erayd on jsonrainbow#563
* turning yoda style off to preserve previous behaviour
* some EOL versions of php require an older version of php-cs-fixer
* attempting to normalise behaviour with php-cs-fixer 2.2
* attempt separate run of php 7.0 to avoid having xdebug loaded when running php-cs-fixer
@erayd erayd self-assigned this Sep 25, 2019
@erayd erayd merged commit 44c6787 into jsonrainbow:5.x.x Sep 25, 2019
@erayd erayd deleted the backport-529 branch September 25, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants