5.x.x: Update validate-json to use spl_autoload_register #589
Conversation
sanmai
changed the title
|
Thank you @sanmai :-). |
|
Guys, could you please tag a new release with this fix? |
|
@maks-rafalko Yes. I want to roll a few other backported fixes in too. |
|
A release with just this fix will be very appreciated because it is a major deprecation since PHP 7.2. Almost everyone these days is getting PHP 7.3 from the start, e.g. because Debian stable includes one. Thank you very much for considering this request. |
|
@sanmai Are you requesting a release ASAP, or are you specifically wanting a release with that fix only in it? Because I'm doing the backports now, and should be tagging stuff in a few minutes. |
## Backported PRs * #559 ArraysTest for array items with enum validation * #567 Don't run checks which assume a defined instance against undefined * #575 Tests on PHP 7.3 * #587 Fixed PHPDoc of Validator::validate() method * #583 Fix travis PHP 5.4 and 5.5 config ## Additional PRs (5.x.x only) These PRs are only applicable to the 5.x.x branch, and have been merged individually. * #589 Update validate-json to use spl_autoload_register ## Skipped PRs * #464 marc-mabe/php-enum versions (dependency not present in 5.x.x)
|
@maks-rafalko I've just tagged v5.2.9 with all current backports merged in. @sanmai Please let me know if you need an additional release that contains only the autoload fix - that seems like a rather strange thing to ask for, so I'd prefer not to do it without a good reason. |
|
Thank you! |
This wasn't necessary absolutely. I meant that if you're busy with other things tagging a release with just this fix would be a big help. But else any release works. Thank you again. |
Fixes #574
spl_autoload_registerexists since PHP 5.1, so this shouldn't be a problem backward-compatibility wise.