Skip extension builds for default gems #8415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be issues launching these subprocesses via Maven. While we investigate that, temporarily disable extension building for default gems. The problem manifests during the default gem install of the fiddle gem, which generates a dummy Makefile on JRuby because it uses the FFI version instead. The launch of extconf.rb exhibits problems in various environments: * In CI, it ends up running with the system default Java rather than the one configured in JAVA_HOME. * On local Linux environments, it fails to launch due to a "bar file descriptor: /bin/sh" error. It seems that the subprocess launch is losing environment in some broken way.
headius
force-pushed
the
skip_default_gem_extensions
branch
from
d4849c5 to
280b0f8
Compare
|
This appears to work fine but @enebo pointed out we will eventually need this to start building exts again for the prism gem. For now, this will allow 9.4 (master) and 10 to build without running into the env issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be issues launching these subprocesses via Maven. While we investigate that, temporarily disable extension building for default gems.
The problem manifests during the default gem install of the fiddle gem, which generates a dummy Makefile on JRuby because it uses the FFI version instead. The launch of extconf.rb exhibits problems in various environments:
It seems that the subprocess launch is losing environment in some broken way.