Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize roundUpToPowerOfTwo #6067

Merged
merged 1 commit into from
Feb 17, 2020
Merged

optimize roundUpToPowerOfTwo #6067

merged 1 commit into from
Feb 17, 2020

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Feb 15, 2020 •
edited
Loading

fewer lines of code + a little bit faster

@headius
Copy link
Member

headius commented Feb 17, 2020

The Java version of numberOfLeadingZeros has a similar implementation, but I suspect it's faster because it's also an "intrinsic" on Hotspot (meaning it will use whatever is optimal on each platform.

I'm 👍 on this.

@headius headius added this to the JRuby 9.2.10.0 milestone Feb 17, 2020
@headius headius merged commit 7d6a336 into jruby:master Feb 17, 2020
@headius
Copy link
Member

headius commented Feb 17, 2020

Just under the wire for 9.2.10!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ahorek @headius