Minor improvements #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated. I added Travis CI support and dependency badge. You will need to enable Travis yourself though. |
Remove unused variables, keep style consistent.
Specify the files when installing.
Use more code syntax.
|
I'd like to leave out the Travis CI badge and the dependency badge. |
|
Can you share why is that? Just wondering. Personally I find it useful having them. |
|
Might enable once the 4.0.x branch is ready to be merged in. |
|
So you still want me to remove them? |
|
Yes please. Thanks. |
|
Updated. |
|
Added the badges patches in another branch https://github.com/XhmikosR/jquery-mousewheel/compare/badges. Do you want me to make a new PR for that? |
|
Thanks and feel free to make another pull request for the badges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.