Attributes: Don't stringify attributes in the setter #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
commented
Oct 7, 2021
mgol
added
Discuss in Meeting
timmywil
removed
the
Discuss in Meeting
mgol
force-pushed
the
trusted-types-attributes
branch
from
5965d0b to
8497cd0
Compare
|
There still seems to be an error on travis related to this PR. |
Stringifying attributes in the setter was needed for IE <=9 but it breaks trusted types enforcement when setting a script `src` attribute. Note that this doesn't mean script execution works. Since jQuery disables all scripts by changing their type and then executes them by creating fresh script tags with proper `src` & possibly other attributes, this unwraps any trusted `src` wrappers, making the script not execute under strict CSP settings. We might try to fix it in the future in a separate change. Fixes jquerygh-4948
mgol
force-pushed
the
trusted-types-attributes
branch
from
8497cd0 to
2773427
Compare
|
@timmywil the issue was not clearing CSP logs after the test which affected other tests looking at those logs. I added the clearing and tests are passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stringifying attributes in the setter was needed for IE <=9 but it breaks
trusted types enforcement when setting a script
srcattribute.Note that this doesn't mean script execution works. Since jQuery disables all
scripts by changing their type and then executes them by creating fresh script
tags with proper
src& possibly other attributes, this unwraps any trustedsrcwrappers, making the script not execute under strict CSP settings.We might try to fix it in the future in a separate change.
Fixes gh-4948
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com