Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Skip the "jQuery.ajax() on unload" test in Safari #4779

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Tests: Skip the "jQuery.ajax() on unload" test in Safari #4779

merged 1 commit into from
Sep 2, 2020

Conversation

mgol
Copy link
Member

@mgol mgol commented Aug 26, 2020

Summary

The test has been already skipped in Chrome as it dropped support for such
requests and now Safari has joined the squad.

This will resolve AJAX test errors we've had for a while in Safari 13 & iOS 13.

Checklist

@mgol mgol added Needs review Tests Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Aug 26, 2020
@mgol mgol added this to the 3.6.0 milestone Aug 26, 2020
@mgol mgol self-assigned this Aug 26, 2020
@mgol
Copy link
Member Author

mgol commented Aug 26, 2020

Travis fails because of a bug that's fixed in #4778. I'll rebase the PR when that lands & will make sure Travis passes before landing.

@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Aug 31, 2020
timmywil
timmywil approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending a comment on checking for legacy edge

mgol
mgol commented Aug 31, 2020
View reviewed changes
test/unit/ajax.js Show resolved Hide resolved
@mgol
Tests: Skip the "jQuery.ajax() on unload" test in Safari
fcf9470 
The test has been already skipped in Chrome as it dropped support for such
requests and now Safari has joined the squad.

This will resolve AJAX test errors we've had for a while in Safari 13 & iOS 13.
@mgol mgol force-pushed the ajax-sync-unload-skip branch from 70d9c62 to fcf9470 Compare September 2, 2020 15:27
@mgol mgol removed the Needs review label Sep 2, 2020
@mgol mgol merged commit c18dc49 into jquery:master Sep 2, 2020
@mgol mgol deleted the ajax-sync-unload-skip branch September 2, 2020 16:04
mgol added a commit that referenced this pull request Sep 2, 2020
@mgol
Tests: Skip the "jQuery.ajax() on unload" test in Safari
4f016c6 
The test has been already skipped in Chrome as it dropped support for such
requests and now Safari has joined the squad.

This will resolve AJAX test errors we've had for a while in Safari 13 & iOS 13.

Closes gh-4779

(cherry picked from commit c18dc49)
@mgol
Copy link
Member Author

mgol commented Sep 2, 2020

Landed on master in c18dc49 & on 3.x-stable in 4f016c6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels
Tests
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mgol @timmywil