Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes: Don't set the type attr hook at all outside of IE #4587

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Attributes: Don't set the type attr hook at all outside of IE #4587

merged 1 commit into from
Jan 13, 2020

Conversation

mgol
Copy link
Member

@mgol mgol commented Jan 8, 2020 •
edited
Loading

Summary

This removes a needless function call in modern browsers.

+3 bytes

Checklist

@mgol mgol added the Attributes label Jan 8, 2020
@mgol mgol self-assigned this Jan 8, 2020
@mgol mgol changed the title Attributes: Don't set the type attrHooks at all outside of IE Attributes: Don't set the type attr hook at all outside of IE Jan 8, 2020
@mgol
Attributes: Don't set the type attr hook at all outside of IE
4ec4a7e 
This removes a needless function call in modern browsers.
@mgol mgol force-pushed the attrhooks-type-perf branch from 5092f27 to 4ec4a7e Compare January 8, 2020 17:24
dmethvin
dmethvin approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@mgol mgol merged commit 9e66fe9 into jquery:master Jan 13, 2020
@mgol mgol deleted the attrhooks-type-perf branch January 13, 2020 18:22
@mgol mgol added this to the 4.0.0 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

@dmethvin dmethvin dmethvin approved these changes

Assignees

@mgol mgol

Labels
Attributes
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mgol @dmethvin @timmywil