fix: flush validations on submit #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
reviewed
Aug 3, 2020
| const handleSubmit = (e?: React.SyntheticEvent) => { | ||
| if (e && e.preventDefault) e.preventDefault(); | ||
| clearPendingValidations(); |
There was a problem hiding this comment.
@AaronBuxbaum why do we need to clear pending validations here, if we're going to clear them more-or-less immediately afterward in submit below?
There was a problem hiding this comment.
@jquense suggested adding it in both places in case consumers call submit directly. That said it does seem like it gets resolved with that single usage anyway. I want to check with Jason just in case there's some reason I'm unaware of that we need this line, but it does look like these do end up calling line 442 anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.