Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify docs for copy*() filter #884

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Clarify docs for copy*() filter #884

merged 2 commits into from
Apr 8, 2021

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Apr 2, 2021

Fixes #843

@RyanZim RyanZim requested review from JPeer264 and manidlou April 2, 2021 22:41
manidlou
manidlou reviewed Apr 6, 2021
View reviewed changes
docs/copy-sync.md Outdated Show resolved Hide resolved
@RyanZim RyanZim requested a review from manidlou April 7, 2021 14:33
manidlou
manidlou approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@manidlou manidlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanZim RyanZim merged commit 24731f1 into master Apr 8, 2021
@RyanZim RyanZim deleted the ryan/copy-docs branch April 8, 2021 17:35
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manidlou manidlou manidlou approved these changes

@JPeer264 JPeer264 Awaiting requested review from JPeer264

Assignees
No one assigned
Labels
documentation feature-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[copy] filter is applied to directories, even though docs say it's just applied to files
3 participants
@RyanZim @JPeer264 @manidlou