-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with fs.extra and mkdirp #2
Comments
Hmm, good point. Your |
Shall we move it all into your repo? my I think What do you think? |
Hehehe... looks like you just updated yours. ;p |
My concern is one of API naming consistency. Node's own
Anyway, to what we are discussing, I don't mind either naming scheme as long as its consistent. As it stands now in your The problem with this is that it's unpredictable and unintuitive to new users of the API. So, I'm in favor of naming them all similar. If you want to keep Thoughts? |
And either I need to create a new repo for the fs.extra stuff I have, or I can move my stuff to your repo. Also, I found another library that's pulling in stuff |
OK, +1 for consistency.
|
OK, I've decide that I'm going to implement all of these methods. But, I'm naming them in the terse unixy manner. The reason that I chose this is to be consistent with the naming scheme chosen by Node. Take a look at http://nodejs.org/api/fs.html#fs_class_fs_stats. With the exception of @coolaj86 I'd still love to know any of your thoughts on this matter. |
Yes, I think the terse names are a great idea. Yes, there are significant benefits to both your My walk doesn't continue walking until you call Your method for
https://github.com/substack/node-mkdirp/issues/17#issuecomment-5864594 |
(To be clear, the walker that I presented as a comparison to yours, isn't mine.) Wow, I just read through all of those including @isaacs great essay. It's almost as if everyone read your words, but no one quite understood what you said, so to speak. I have massive respect for these individuals, but it almost seems as if everything went right over their head. Here are your points, as I understand them:
If I've accurately stated your points, then I'm not sure how the discussion in https://github.com/substack/node-mkdirp/issues/17#issuecomment-5874346 missed your points. Did I accurately state your points? By the way, as a fellow member of the Node community, I appreciate your pragmatic thinking on this matter. |
Yes, those are my points. But people didn't see the ideas as distinctly as you. The conversation morphed from one topic to another and it seems that some people didn't follow that the topic was changing and thought that upcoming arguments were in support of the original topic (let's get the author to give up mkdirp in favor of blessed fs tools). The other thing is that people sway from top to bottom. i.e. manic depression. If you were just in an iron-fisted community your next community will naturally be one of anarchy. Over time you decide you don't like anarchy and switch back to something almost iron-fisted, then you swing back to something not quite anarchy, and eventually you land in the middle. I think it's a herd mentality of people who were slapped in the face by either side of the argument and still believe that the middle is too close to the side that bit them. Give it a few years and node will be closer to the middle and a new community will surface that's either iron-fisted or anarchic and the pattern with repeat. |
I know this discussion is old, but IMO this module should be split up into several modules, one for each action, i.e. That would alleviate the need to merge with |
-1 for splitting package. This package is great because it combines several others into one API. If you just need some of it use the underlying modules. |
This is old enough that it can be closed. It spawned excellent discussion and encouraged a lot of thinking on my end. Directions have been established and momentum has been achieved. I'm still open and willing to collaborate or perhaps even join forces, but if that should happen, let's move that over to a new discussion. |
Would be nicer to have a single fs-extra or fs.extra module with all of the little extras in one.
https://github.com/coolaj86/node-examples-js/tree/master/fs.extra
https://github.com/substack/node-mkdirp
The text was updated successfully, but these errors were encountered: