Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dyn from structs #222

Merged
merged 7 commits into from
Feb 4, 2024
Merged

Remove dyn from structs #222

merged 7 commits into from
Feb 4, 2024

Conversation

phenylshima
Copy link
Member

@phenylshima phenylshima commented Feb 2, 2024

ref: #221

Remove dyn from struct definition as possible, and add support for multithreading.

Breaking Changes

  • WordDictionaryConfig was removed (in other words: renamed to DefaultFetcher and heavily modified)
  • DictionaryStore no longer has serlializer_hint function
  • JPreprocess struct requires type parameter F
  • JPreprocess's deprecated new function is finally removed

@phenylshima phenylshima self-assigned this Feb 2, 2024
@phenylshima phenylshima changed the title Multithread Remove dyn from structs Feb 2, 2024
@phenylshima phenylshima marked this pull request as draft February 2, 2024 12:06
@phenylshima phenylshima force-pushed the multithread-dictionary branch from 1ffd19a to 1be6769 Compare February 2, 2024 12:36
@phenylshima phenylshima marked this pull request as ready for review February 3, 2024 03:56
This was referenced Feb 3, 2024
@eyr1n
Copy link

eyr1n commented Feb 4, 2024

https://github.com/eyr1n/voicevox_core/blob/f189b15e5291dcc6952232b8630277bd2f0c4796/crates/voicevox_core/src/text_analyzer.rs#L144
にて上記変更を取り込み試してみました.
特に問題なさそうです.

@phenylshima
Copy link
Member Author

ご確認ありがとうございます.
ではこれでいこうと思います.

@phenylshima phenylshima merged commit 93063ce into main Feb 4, 2024
3 checks passed
@phenylshima phenylshima deleted the multithread-dictionary branch February 4, 2024 07:50
@eyr1n
Copy link

eyr1n commented Feb 4, 2024

一連の対応ありがとうございますm(__)m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants