270 fix len logic2 (#1) #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the first element of class(order.by) is used in the if statement. This will emit an error or warning when the environment variable _R_CHECK_LENGTH_1_LOGIC2_ is true. We should make this explicit to avoid the error or warning. Fixes joshuaulrich#270.
joshuaulrich
force-pushed
the
270_fix_len2
branch
from
f88fe13 to
4bb73f3
Compare
|
Thanks for your patch! I only made a few changes to the commit message. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When class(order.by) has a length other than one, it will reach this
line but only the first element will be used. We should make this
explicit and indeed must in case the environment variable R_CHECK_LENGTH_1_LOGIC2 is set, whereupon this line will emit an error
or warning.