-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible regression in plot.xts titles when using layout #412
Comments
Thanks for the report! I'll take a look. Reproducible example below. Note that the header isn't clipped if you make the X11 window larger. library(xts)
data(sample_matrix)
x <- as.xts(sample_matrix)
x11()
layout(matrix(1:2,2,1,byrow=TRUE), heights=c(1,1,1,1))
plot(x[,1], main="Chopped")
plot(x[,1], main="Clipped") |
This should be fixed on the 412-plot-header-clipped branch. Please test and let me know if you find any issues. Thanks! |
Damn straight -- you are correct on the resize. Had not noticed. So where did behaviour change? In base R? Not so likely? So was this a side-effect from recent cleanup? |
Yeah, I did a significant refactor of all the plot functionality. It was practically necessary in order to get the log y-axis working.
Awesome, thanks for testing that too! |
# xts 0.14.x (202x-xx-xx) * `plot.xts()` now renders all panels when 'x' has more than 8 columns and `multi.panel = TRUE`. Columns 9 and later didn't render because the default of `plot.xts()` is 'col = 1:8'. Thanks to Ethan Smith for the report and patch. ([#423](joshuaulrich/xts#423)) ([#424](joshuaulrich/xts#424)) * `plot.xts()` no longer errors when 'ylim' is constant and negative. Thanks to Ethan Smith for the report. ([#422](joshuaulrich/xts#422)) * Do not use `SET_TYPEOF()` in C because it is not part of the public R API. * `merge.xts()` no longer converts 'x' or 'y' from double to integer in the C code when they are not used in the result. This avoids an unnecessary and confusing warning. Thanks to Jeff Ryan for the report. # xts 0.14.0 (2024-06-05) * `addEventLines()` and `addLegend()` now draw on multiple panels when `on` is a vector. Thanks to Ethan Smith for the report. ([#420](joshuaulrich/xts#420)) * Replace `SET_TYPEOF()` in merge.c because it will error when it tries to convert a REAL to an INTEGER. Thanks to Kurt Hornik for the report! ([#419](joshuaulrich/xts#419)) * Fix crash when 'j' is not an integer and in [0, 1) (e.g. `j = 0.1`). Also throw a warning when 'j' is not an integer. ([#413](joshuaulrich/xts#413)) ([#415](joshuaulrich/xts#415)) * Fix plot header when `layout()` is used to draw multiple plots on a single device. Thanks to Dirk Eddelbuettel for the report and testing! ([#412](joshuaulrich/xts#412)) * Fix plot legend location when the y-axis is log scale. ([#407](joshuaulrich/xts#407)) # xts 0.13.2 (2024-01-21) * Print a message when `period.apply()` is called with `FUN = mean` because it calculates the mean for each column, not all the data in the subset like it does for all other functions. The message says to use `FUN = colMeans` for current behavior and `FUN = function(x) mean(x)` to calculate the mean for all the data. This information is also included in the help files. The option `xts.message.period.apply.mean = FALSE` suppresses the message. ([#124](joshuaulrich/xts#124)) * Fix error when `print.xts()` is called 'quote' or 'right' arguments. ([#401](joshuaulrich/xts#401)) * Fix `addPolygon()` so it renders when `observation.based = TRUE`. ([#403](joshuaulrich/xts#403)) * Print trailing zeros for index value with fractional seconds, so every index value has the same number of characters. ([#404](joshuaulrich/xts#404)) * Add ability to log scale the y-axis in `plot.xts()`. ([#103](joshuaulrich/xts#103)) * Actually change the underlying index values when 'tclass' is changed from a class with a timezone (e.g. POSIXct) to one without a timezone (e.g. Date). Add a warning when this happens, with a global option to always suppress the warning. ([#311](joshuaulrich/xts#311)). * Significantly refactor the internals of `plot.xts()`. ([#408](joshuaulrich/xts#408))
Description
We now see the titles 'chopped off' ie clipped ie parts are outside the visible region. That is new, and a regression.
It does not seem to appear on a single plot but when combined via
layout()
it clearly is an issue.I have a recurrent cronjob plotting (several pages of) three plot a page to pdf where I noticed it first. It is more prevalent for n=3.
Expected behavior
No clipping, ie see the full text.
Minimal, reproducible example
Session Info
The text was updated successfully, but these errors were encountered: