Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control number of ticks on y-axis #374

Closed
FredrikWartenberg opened this issue Oct 3, 2022 · 4 comments
Closed

Control number of ticks on y-axis #374

FredrikWartenberg opened this issue Oct 3, 2022 · 4 comments
Assignees
@joshuaulrich
Labels
enhancement Enhancement to existing feature
Milestone
0.12.2

Comments

@FredrikWartenberg
Copy link

FredrikWartenberg commented Oct 3, 2022 •
edited
Loading

Hi Joshua,
I have a branch on a local clone of xts with a minor improvement to plot.xts allowing to increase the number of ticks on the y-axis. If it is of general interest, I'd like to make it a pull request, but I have no rights to push my branch.
regards,
Fredrik

From ?plot.xts
yticks.density

Density of tickmarks on y axis. The density will be increased by the given factor (default = 1). The number of tickmarks is determined by means of the pretty function with n = 5 * yticks.desnity.
@joshuaulrich
Copy link
Owner

Thanks for your contribution!

You have a couple options:

  1. Fork this repo to create a copy under your account. Then make your changes on a branch in that repo. You can submit a pull request once they're committed and pushed to your forked copy.
  2. Use the command line: git checkout {your-branch-name} && git format-patch master. That will create patch files you can send me.

Let me know if you need help with either of those.

@FredrikWartenberg
Copy link
Author

FredrikWartenberg commented Oct 3, 2022 via email

@joshuaulrich
Copy link
Owner

@FredrikWartenberg I don't see a patch in your comment. If you attached it to your email, GitHub probably stripped it because you replied to an issue comment. You can send it to my personal email: maintainer("xts").

@FredrikWartenberg
Copy link
Author

0001-Add-yticks.density-as-argument-to-plot-allowing-to-c.patch.gz

Hope it works this way

@joshuaulrich joshuaulrich added the enhancement Enhancement to existing feature label Oct 7, 2022
@joshuaulrich joshuaulrich added this to the 0.12.2 milestone Oct 7, 2022
@joshuaulrich joshuaulrich self-assigned this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuaulrich joshuaulrich

Labels
enhancement Enhancement to existing feature
Projects
None yet
Milestone
0.12.2
Development

No branches or pull requests
2 participants
@joshuaulrich @FredrikWartenberg