Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cruft from Karabiner config, use the same rotary encoder bindings on MacOS as on Windows #7

Merged
merged 3 commits into from
Jul 24, 2020

Conversation

james-milloff
Copy link
Contributor

This removes some configuration from the karabiner config that don't affect the Hub16. These removals make it easier for a first time Karabiner use to understand the configuration. These removals are

  • Removing device entries that aren't for the Hub16.
  • Remove the F key mappings. Karabiner automatically adds these when you click the checkbox at the bottom of the function keys tab.

This PR also updates the rotary encoder bindings to do the same thing that the Windows AHK script does. Previously, the rotary encoder directions were also backwards when compared to the Windows bindings.

For example, turning the volume knob clockwise would increase the volume on Windows, but decrease it on Mac.

@joshajohnson
Copy link
Owner

Thanks!
I don't have a mac to test on so never caught those issues - should probably borrow one...
Some of the earlier boards shipped with encoders that had the encoder directions flipped, so that may explain the difference there.
I also just noticed that Karabiner uses VID:PID for detection, which have changed in recent releases (to enable VIA support) which might cause some issues. I'll work on updating the files & documentation to cover this.

@joshajohnson joshajohnson merged commit 49861f2 into joshajohnson:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants