Improve bash examples. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also http://www.shellcheck.net/ * examples/bash/count.sh,README.md: `seq` is nonstandard, inefficient. Use shell built-in loop feature instead. * examples/bash/dump-env.sh: Double quote to prevent globbing (SC2086) * examples/bash/send-receive.sh: Use _ for unused variable; Improved use of shell arithmetic ((cnt++)); Use $().
|
All these work in 5+ year old bash on BSD. Should be good to merge. Unless anyone disagrees I'll go forward with it in day or so. |
|
LGTM. Also update the homepage (index.html in gh-pages branch) |
asergeyev
added a commit
that referenced
this pull request
Feb 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also http://www.shellcheck.net/
seqis nonstandard, inefficient.Use shell built-in loop feature instead.
of shell arithmetic ((cnt++)); Use $().