Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use generic downloader for Linux/Mac #40

Merged
merged 15 commits into from
Jul 28, 2020

Conversation

joergi
Copy link
Owner

@joergi joergi commented Jul 12, 2020

will close #39

@joergi joergi added this to the using generic scripts milestone Jul 12, 2020
@joergi joergi marked this pull request as ready for review July 13, 2020 21:19
@joergi joergi requested a review from rubemlrm July 13, 2020 21:19
@joergi joergi changed the title Update magpi-issue-downloader.sh use generic downloader for Linux/Mac Jul 13, 2020
@joergi joergi self-assigned this Jul 13, 2020
@joergi joergi added code quality Windows OS this is all related to the windows version Linux OS Mac OS enhancement and removed Windows OS this is all related to the windows version labels Jul 13, 2020
@joergi
Copy link
Owner Author

joergi commented Jul 13, 2020

feel free to have a look @rubemlrm - if you like it, approve it
(but you can also merge it, if you want to)

@rubemlrm
Copy link
Contributor

@joergi with this approach user it will download everything? Looks that user looses the option to set a limit from the shell script call.

@joergi
Copy link
Owner Author

joergi commented Jul 14, 2020

@rubemlrm no the magpi-issue-downloader.sh works as before.
You never call the generic downloader.
The project will work, as before.
It's just, that we don't need the same script in every project (magpi/helloworld/wireframe/hackspace)
The tests with the limits are still working

@joergi joergi marked this pull request as draft July 21, 2020 08:37
@joergi joergi removed the request for review from rubemlrm July 21, 2020 11:02
@joergi joergi changed the base branch from master to main July 26, 2020 20:43
@joergi joergi marked this pull request as ready for review July 28, 2020 20:13
@joergi joergi merged commit 84553a5 into main Jul 28, 2020
@joergi joergi deleted the issue_39_use_generic_download_script branch July 28, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use generic downloader (Mac/Linux)
2 participants