Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Use provider names in error messages #315

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

SRWieZ
Copy link
Contributor

@SRWieZ SRWieZ commented Nov 17, 2023

Summary

Fix OAuth callback error message

Explanation

The OAuth callback error was not displaying the provider name in the message.

when using a config like this, without Label:

return [
    'middleware' => ['web'],
    'prompt' => 'Or Login Via',
    'providers' => [
        Providers::github(),
    ],
];

Checklist

  • I've read this template
  • I've checked reviewed this PR myself, ensuring consistency and quality with the rest of the project
  • I've given a good reason as to why this PR exposes new / removes existing user data

@joelbutcher
Copy link
Owner

Nice one, thanks!

@joelbutcher joelbutcher changed the title Fix callback error message [5.x] Use provider names in error messages Nov 17, 2023
@joelbutcher joelbutcher merged commit fc376e4 into joelbutcher:5.x Nov 17, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants