Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load FA5 if necessary #535

Merged
merged 12 commits into from
Apr 11, 2022
Merged

Only load FA5 if necessary #535

merged 12 commits into from
Apr 11, 2022

Conversation

cp2004
Copy link

@cp2004 cp2004 commented Apr 10, 2022

OctoPrint bundles FA5 since 1.5.0, so on newer versions it doesn't need to be loaded

Sorry, forgot to check which branch the PR should go to. Let me know if it needs rebasing.

billygr and others added 11 commits January 22, 2022 10:39
The proposed UBL setup doesn't actual save the mesh to slot 0, following a reboot the mesh will not be loaded (because it was never saved)

Reference: https://marlinfw.org/docs/gcode/G029-ubl.html
config for ARTILLERY SIDEWINDER X2
When using one of these:

//#define RESTORE_LEVELING_AFTER_G28
//#define ENABLE_LEVELING_AFTER_G28

The bed leveling corrections could be turned on after G28.
In my tests it, that this could throw off all measurements,
because of Z-Code offset.
Making sure bed leveling is OFF before probing
OctoPrint bundles FA5 since 1.5.0, so on newer versions it doesn't need to be loaded
@jneilliii jneilliii changed the base branch from master to rc April 11, 2022 03:36
@jneilliii jneilliii merged commit 319cb56 into jneilliii:rc Apr 11, 2022
@jneilliii
Copy link
Owner

rebased to RC, resolved conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants