docs: spelling correction #2190
Conversation
jina-bot
added
size/S
area/core
jina/parsers/client.py
Outdated
| @@ -36,7 +36,7 @@ def mixin_client_cli_parser(parser): | |||
| gp.add_argument( | |||
| '--top-k', | |||
| type=int, | |||
| help='The number of results will be returned. Sorted by their scores descendingly.', | |||
| help='The number of results will be returned. Sorted by their scores in descending order.', | |||
There was a problem hiding this comment.
We should remove this part, it is not guaranteed to be returned sorted in descending order
There was a problem hiding this comment.
wow okay, I didn't know that. Interesting.
Is it because the rankers can change the sorting?
There was a problem hiding this comment.
well, it is because it depends if u sort or not them, or if they come right after a Vector Search (where score is distance)
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
+ Coverage 90.41% 90.50% +0.08%
==========================================
Files 208 208
Lines 11243 11243
==========================================
+ Hits 10165 10175 +10
+ Misses 1078 1068 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
| @@ -176,15 +176,15 @@ def write_handler(self): | |||
| return r | |||
|
|
|||
| def get_query_handler(self): | |||
| """Get a *readable* index handler when the ``index_abspath`` already exist, need to be overrided""" | |||
| """Get a *readable* index handler when the ``index_abspath`` already exist, need to be overridden""" | |||
There was a problem hiding this comment.
just curious, should it be overwritten? checkout this link
There was a problem hiding this comment.
You override a method, not overwrite it
There was a problem hiding this comment.
No description provided.