Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for D-pad navigation using a Android TV remote control #586

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

danielz-nenda
Copy link
Contributor

This is needed in order to run the example app on an Android TV device.

@jhomlala
Copy link
Owner

jhomlala commented Jul 8, 2021

LGTM, thanks!

@jhomlala jhomlala changed the base branch from master to feature/july_changes July 8, 2021 15:15
@jhomlala jhomlala merged commit ba04998 into jhomlala:feature/july_changes Jul 8, 2021
@jhomlala jhomlala self-assigned this Jul 8, 2021
jhomlala added a commit that referenced this pull request Jul 9, 2021
* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (#586)

* Exposes all active eventListener (#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
creativeblaq pushed a commit to creativeblaq/betterplayer that referenced this pull request Jul 9, 2021
* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (jhomlala#586)

* Exposes all active eventListener (jhomlala#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
creativeblaq pushed a commit to creativeblaq/betterplayer that referenced this pull request Jul 9, 2021
* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (jhomlala#586)

* Exposes all active eventListener (jhomlala#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
jhomlala added a commit that referenced this pull request Aug 15, 2021
* Better UI Changes

* Update ci.yml

* Feature/july changes (#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (#586)

* Exposes all active eventListener (#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* Updated docs

* Updated docs

* Updated docs

* Updated docs

* fixed conflicts

* Duplicated named argument 'onLongPress' removed

* Better UI Changes

* Feature/july changes (#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (#586)

* Exposes all active eventListener (#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* fixed conflicts

Co-authored-by: Jakub <jhomlala@gmail.com>
Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
jhomlala added a commit that referenced this pull request Aug 15, 2021
* Added licenseUrl support for iOS DRM.

* Fixed RTL text direction issue in player controls.

* Updated normal player page

* Added currently displayed subtitle

* Added additional check in `postControllerEvent` to handle scenario where event stream is closed.

* Updated ExoPlayer version

* Buffering fix in Android, video list update

* * Added `setMixWithOthers` method in `BetterPlayerListVideoPlayerController`.

* Fixed broken ling in cover page of documentatio

* Fixed progress bar issue where position could be set above video duration

* Fixed iOS remote notification command issu

* Update welcome_page.dart (#607)

Removed duplicated page

* Removed duplicated page in example app (by https://github.com/pinguluk)

* Added support for ClearKey DRM for File Datasource. (#566)

* Added support for ClearKey DRM for File Datasource.

* Formatting of ClearKey implementation code.

* Added ClearKey support for BetterPlayerDataSourceType.network and BetterPlayerDataSourceType.memory for Android.

* Added ClearKey DRM to new documentation format.

* Clear key DRM update

* Better UI Changes (#594)

* Better UI Changes

* Update ci.yml

* Feature/july changes (#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (#586)

* Exposes all active eventListener (#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* Updated docs

* Updated docs

* Updated docs

* Updated docs

* fixed conflicts

* Duplicated named argument 'onLongPress' removed

* Better UI Changes

* Feature/july changes (#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (#586)

* Exposes all active eventListener (#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* fixed conflicts

Co-authored-by: Jakub <jhomlala@gmail.com>
Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* Updated changelog

* Added `sigmaX` and `sigmaY` parameters in BetterPlayerControlsConfiguration

* Updated lint and format

* Updated versions

Co-authored-by: Pinguluk <luca_paun@yahoo.com>
Co-authored-by: tinusneethling <59045462+tinusneethling@users.noreply.github.com>
Co-authored-by: creativeblaq <76699978+creativeblaq@users.noreply.github.com>
Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
geriby23 pushed a commit to threadable/betterplayer that referenced this pull request Jul 16, 2024
* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (jhomlala#586)

* Exposes all active eventListener (jhomlala#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
geriby23 pushed a commit to threadable/betterplayer that referenced this pull request Jul 16, 2024
* Added licenseUrl support for iOS DRM.

* Fixed RTL text direction issue in player controls.

* Updated normal player page

* Added currently displayed subtitle

* Added additional check in `postControllerEvent` to handle scenario where event stream is closed.

* Updated ExoPlayer version

* Buffering fix in Android, video list update

* * Added `setMixWithOthers` method in `BetterPlayerListVideoPlayerController`.

* Fixed broken ling in cover page of documentatio

* Fixed progress bar issue where position could be set above video duration

* Fixed iOS remote notification command issu

* Update welcome_page.dart (jhomlala#607)

Removed duplicated page

* Removed duplicated page in example app (by https://github.com/pinguluk)

* Added support for ClearKey DRM for File Datasource. (jhomlala#566)

* Added support for ClearKey DRM for File Datasource.

* Formatting of ClearKey implementation code.

* Added ClearKey support for BetterPlayerDataSourceType.network and BetterPlayerDataSourceType.memory for Android.

* Added ClearKey DRM to new documentation format.

* Clear key DRM update

* Better UI Changes (jhomlala#594)

* Better UI Changes

* Update ci.yml

* Feature/july changes (jhomlala#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (jhomlala#586)

* Exposes all active eventListener (jhomlala#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* Updated docs

* Updated docs

* Updated docs

* Updated docs

* fixed conflicts

* Duplicated named argument 'onLongPress' removed

* Better UI Changes

* Feature/july changes (jhomlala#598)

* Fixed play after seeking issue on iOS

* Fixed audio track selection issue on iOS/Android

* Fixed issue where speed which couldn't be applied on iOS was saved in player state.

* Added support for D-pad navigation using a Android TV remote control (jhomlala#586)

* Exposes all active eventListener (jhomlala#585)

* Updated changelog

* Added docs

* Updated documentation

* Updated documentation

* Added BetterPlayerMultipleGestureDetector, general refactor

* General refactor

Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* fixed conflicts

Co-authored-by: Jakub <jhomlala@gmail.com>
Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>

* Updated changelog

* Added `sigmaX` and `sigmaY` parameters in BetterPlayerControlsConfiguration

* Updated lint and format

* Updated versions

Co-authored-by: Pinguluk <luca_paun@yahoo.com>
Co-authored-by: tinusneethling <59045462+tinusneethling@users.noreply.github.com>
Co-authored-by: creativeblaq <76699978+creativeblaq@users.noreply.github.com>
Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com>
Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants