Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of an hardcoded string #53

Closed
aleclerc7 opened this issue Mar 15, 2022 · 1 comment
Closed

Translation of an hardcoded string #53

aleclerc7 opened this issue Mar 15, 2022 · 1 comment
Assignees
@jgonyea
Labels
bug

Comments

@aleclerc7
Copy link
Contributor

Hello,

partials/podcast_episodes_list.html line 33 has:

                    {{ (datestamp)|nicetime(false) }}{% if e.header.podcast.audio.meta %} | <a href ="{{ e.header.podcast.audio.meta.guid }}">Download Audio</a>{% endif %}

it should be:

                    {{ (datestamp)|nicetime(false) }}{% if e.header.podcast.audio.meta %} | <a href ="{{ e.header.podcast.audio.meta.guid }}"> {{ 'PLUGIN_PODCAST.EPISODE_CONTENT.DOWNLOAD'|t|e }}</a>{% endif %}

Kind regards.
@jgonyea jgonyea self-assigned this Mar 15, 2022
@jgonyea jgonyea added the bug label Mar 15, 2022
@jgonyea jgonyea changed the title Translation of an hardcoded tring Translation of an hardcoded string Mar 15, 2022
aleclerc7 added a commit to aleclerc7/grav-plugin-podcast-1 that referenced this issue Mar 15, 2022
@aleclerc7
Fix hardcoded string (issue jgonyea#53)
f09bc20 
Fix hardcoded string to use translation system.
@aleclerc7 aleclerc7 mentioned this issue Mar 15, 2022
Merged
jgonyea added a commit that referenced this issue Mar 16, 2022
@jgonyea
Merge pull request #55 from aleclerc7/fix-issue-53
052f087 
Fix hardcoded string in episode listing template (issue #53)
@jgonyea
Copy link
Owner

jgonyea commented Mar 18, 2022

Deployed in latest version.

@jgonyea jgonyea closed this as completed Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgonyea jgonyea

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgonyea @aleclerc7