Fix and features #41
Merged
Fix and features #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
i'm here again (i like so much your library), i've fixed some bugs,
plus i've added the support for nullable enum in the SelectGenerator.
Finally i've separated the default format for the unknwn translations, i've put it in the DefaultCulture, i think it's a good place.
I did it so i can call it in the SelectGenerator, extracting that logic from the LocalizedModelMetadataProvider.
I have slowness issues, so i've implemented a CachedStringProvider, but the first time it get the strings it still remain slow.
I will try to let LocalizedModelMetadataProvider extends CachedDataAnnotationsModelMetadataProvider to see if i gain some speed, but this imply to target the project to the framework 4.5