added anthem translation field as of enhancement issue #21 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added you as a collaborator |
jftsang
reviewed
Aug 2, 2024
forms.py
Outdated
Comment on lines
42
to
44
| anthem_title = StringField('Anthem') | ||
| anthem_composer = StringField('Anthem composer') | ||
| anthem_lyrics = StringField('Anthem lyrics', widget=TextArea()) | ||
| anthem_translation = SelectField('Anthem Translation', choices=translations) |
There was a problem hiding this comment.
I don't know if Flask allows nesting of forms but it might be nice to group these together
models.py
Outdated
| @@ -438,13 +440,14 @@ def from_form(cls, form: 'PewSheetForm') -> 'Service': | |||
| else: | |||
| secondary_feasts = [] | |||
|
|
|||
| if form.anthem_title.data or form.anthem_composer.data or form.anthem_lyrics.data: | |||
| if form.anthem_title.data or form.anthem_composer.data or form.anthem_lyrics.data or form.anthem_translation.data: | |||
There was a problem hiding this comment.
this would be simplified if we could group stuff together
There was a problem hiding this comment.
Okay, I will give it a try!
|
@jftsang, could you review my pull request, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.