Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic Multipart reader/writer implementaion #53

Merged
merged 19 commits into from
Mar 11, 2024
Merged

Generic Multipart reader/writer implementaion #53

merged 19 commits into from
Mar 11, 2024

Conversation

sverdlov93
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • I labeled this pull request with one of the following: 'breaking change', 'new feature', 'bug', or 'ignore for release'

@sverdlov93 sverdlov93 changed the title Multipart reader/writer Generic Multipart reader/writer implementaion Mar 6, 2024
omerzi
omerzi reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@omerzi omerzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it would be better to include internal tests here.

http/multipart/multipart.go Outdated Show resolved Hide resolved
http/multipart/multipart.go Outdated Show resolved Hide resolved
@omerzi
Copy link
Member

omerzi commented Mar 7, 2024

Also, I think that the package should be called "multipartform" to distinguish between the HTTP "multipart/form-data" content type, which is relevant here, and multipart upload.

Or-Geva
Or-Geva suggested changes Mar 10, 2024
View reviewed changes
http/multipart/multipart.go Outdated Show resolved Hide resolved
http/multipart/multipart.go Outdated Show resolved Hide resolved
http/multipart/multipart.go Outdated Show resolved Hide resolved
omerzi
omerzi reviewed Mar 10, 2024
View reviewed changes
http/multipart/multipart.go Outdated Show resolved Hide resolved
http/multipart/multipart.go Outdated Show resolved Hide resolved
http/multipart/multipart.go Outdated Show resolved Hide resolved
http/multipart/multipart.go Outdated Show resolved Hide resolved
http/multipart/multipart_test.go Outdated Show resolved Hide resolved
omerzi
omerzi reviewed Mar 10, 2024
View reviewed changes
http/filestream/filestream.go Outdated Show resolved Hide resolved
http/filestream/filestream_test.go Outdated Show resolved Hide resolved
@sverdlov93 sverdlov93 merged commit b2d67ea into dev Mar 11, 2024
11 of 12 checks passed
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Mar 11, 2024
@omerzi omerzi added new feature Automatically generated release notes and removed improvement Automatically generated release notes labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerzi omerzi omerzi left review comments

@Or-Geva Or-Geva Or-Geva requested changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sverdlov93 @omerzi @Or-Geva