Config profile with repo API integration #797

eranturgeman · 2024-12-10T12:56:52Z

All tests passed. If this feature is not already covered by the tests, I added new tests.
This pull request is on the dev branch.
I used gofmt for formatting the code before submitting the pull request.
Update documentation about new features / new supported technologies

This PR includes the following changes:

Passing Config Profile to Scan-Repo flow (if exists) so it can be utilized in the flow
Introducing new env var that indicates whether we should use config profile or not
Config Profile fetching is not trying to get a profile by name and by associated URL

The failing unit tests are due to a wrong setting in the CI (Currently, we don't run 'go generate' on unit tests, therefore a required package is not found).
I fixed the test.yml CI file and the tests are passing in my fork:

depends on:
jfrog/jfrog-client-go#1057
jfrog/jfrog-cli-security#261

…profile by url

…eXscMockServerForConfigProfile to match new logic

…sion after xsc migration

… correctly

…profile_repos (will not include repository info)

…rl to cli-security

…ofile-with-repo-api-integration

attiasas

Check out my comments and fix tests

utils/params.go

.github/workflows/test.yml

…ofile-with-repo-api-integration # Conflicts: # go.mod # go.sum

…nfigProfile

github-actions · 2024-12-22T10:34:19Z

🐸 JFrog Frogbot

eranturgeman added 4 commits December 10, 2024 09:57

added new env var to indicate requirement to use config profile

8764fd9

updated config profile fetching function to use the new logic of get …

0d51383

…profile by url

added comment on a test

67cdd57

fixed getConfigProfileIfExistsAndValid, added tests and updated Creat…

1da30ba

…eXscMockServerForConfigProfile to match new logic

eranturgeman requested a deployment to frogbot December 10, 2024 12:56 — with GitHub Actions Waiting

eranturgeman changed the title ~~Config profile with repo api integration~~ Config profile with repo API integration Dec 10, 2024

updated test with test case to check deprecated server

9203d2f

eranturgeman requested a deployment to frogbot December 10, 2024 13:02 — with GitHub Actions Waiting

eranturgeman added 2 commits December 10, 2024 15:52

added safety check to verify we use config profile by url only in ver…

50463d5

…sion after xsc migration

improved test to include check of config profile with repo

86b7d03

eranturgeman requested a deployment to frogbot December 10, 2024 14:19 — with GitHub Actions Waiting

redirect go mod to cli-security pr

ca06bb4

eranturgeman requested a deployment to frogbot December 10, 2024 14:40 — with GitHub Actions Waiting

eranturgeman added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Dec 10, 2024

github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 10, 2024

minor fix

0845ab2

eranturgeman requested a deployment to frogbot December 10, 2024 14:46 — with GitHub Actions Waiting

eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 10, 2024

github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 10, 2024

go mod

1fade75

eranturgeman requested a deployment to frogbot December 11, 2024 12:24 — with GitHub Actions Waiting

eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 11, 2024

github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 11, 2024

eranturgeman added 6 commits December 12, 2024 10:41

fixing test files

85c8626

passing ConfigProfile to scanRepository flow

22a9621

fixed getConfigProfileIfExistsAndValid so the repo url can be fetched…

9d7d017

… correctly

fixed test according to changes

96bcc5f

fix test according to latest update on the expected response on POST …

a5938c1

…profile_repos (will not include repository info)

moved the fetching of git repo info to Frogbot and send the fetched u…

b0e4ce0

…rl to cli-security

eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 16, 2024

github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2024

Merge branch 'dev' of https://github.com/jfrog/frogbot into config-pr…

396f7bf

…ofile-with-repo-api-integration

eranturgeman requested a deployment to frogbot December 18, 2024 10:25 — with GitHub Actions Waiting

eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 18, 2024

github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 18, 2024

eranturgeman requested a review from attiasas December 18, 2024 10:36

Merge branch 'dev' of https://github.com/jfrog/frogbot into config-pr…

b790857

…ofile-with-repo-api-integration

eranturgeman temporarily deployed to frogbot December 18, 2024 15:42 — with GitHub Actions Inactive

eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 18, 2024

github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 18, 2024

.

076d9dd

eranturgeman temporarily deployed to frogbot December 19, 2024 07:55 — with GitHub Actions Inactive

eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 19, 2024

github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 19, 2024

attiasas reviewed Dec 21, 2024

View reviewed changes

utils/params.go Outdated Show resolved Hide resolved

utils/params.go Show resolved Hide resolved

utils/params.go Outdated Show resolved Hide resolved

.github/workflows/test.yml Show resolved Hide resolved

eranturgeman added 5 commits December 22, 2024 10:13

Merge branch 'dev' of https://github.com/jfrog/frogbot into config-pr…

11e8aba

…ofile-with-repo-api-integration # Conflicts: # go.mod # go.sum

Cr fix

260ed50

fix break

e22e1f4

attempt to avoid another GetRepositoryInfo if was called before by Co…

8475c58

…nfigProfile

update dependencies to latest versions in client-go and cli-core

c810674

eranturgeman requested a deployment to frogbot December 22, 2024 10:21 — with GitHub Actions Waiting

eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 22, 2024

github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 22, 2024

update dependencies to latest version in security-cli

4f1a3f0

eranturgeman temporarily deployed to frogbot December 22, 2024 10:28 — with GitHub Actions Inactive

eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 22, 2024

github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 22, 2024

eranturgeman merged commit 802ca5b into jfrog:dev Dec 22, 2024
30 of 33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Config profile with repo API integration #797

Config profile with repo API integration #797

eranturgeman commented Dec 10, 2024 •

edited

Loading

attiasas left a comment

github-actions bot commented Dec 22, 2024

Config profile with repo API integration #797

Config profile with repo API integration #797

Conversation

eranturgeman commented Dec 10, 2024 • edited Loading

attiasas left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 22, 2024

eranturgeman commented Dec 10, 2024 •

edited

Loading