Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable allow-partial-results to ScanRepository #762

Merged

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Oct 8, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

This PR introduces a new feature that enable the user to enable partial results for Frogbot ScanRepository SCA scan.
This new feature reduces the amount of times Frogbot will fail the CI run due to a single error, and enable it to skip certain errors and to proceed scanning other parts of the project, while presenting only valid scan results and fixes according to them.
For example in a multi-project environment where we scan several working directories, and the scan have failed for some of the working directories - we will not fail the entire flow, but rather skip the scan and fixes for the failing working directory.

The enablement of this ability is available using JF_ALLOW_PARTIAL_RESULTS (bool) env var.

Related PR: jfrog/jfrog-cli-security#200

@eranturgeman eranturgeman added feature request New feature or request safe to test Approve running integration tests on a pull request labels Oct 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 8, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 8, 2024
@eranturgeman eranturgeman requested a review from attiasas October 8, 2024 13:47
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes and removed feature request New feature or request labels Oct 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 13, 2024
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@eranturgeman eranturgeman merged commit 9d8f6e8 into jfrog:dev Oct 13, 2024
39 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants