-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable allow-partial-results to ScanRepository #762
Merged
eranturgeman
merged 19 commits into
jfrog:dev
from
eranturgeman:enable-partial-results-scan-repo-sca
Oct 13, 2024
Merged
Enable allow-partial-results to ScanRepository #762
eranturgeman
merged 19 commits into
jfrog:dev
from
eranturgeman:enable-partial-results-scan-repo-sca
Oct 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile collecting FrogbotDetails
…the value from ScanDetails to audit params in RunInstallAndAudit
…ror handling after scan phase, vlun mapping phase and fix phase
…lti working dirs) repo
eranturgeman
added
feature request
New feature or request
safe to test
Approve running integration tests on a pull request
labels
Oct 8, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 8, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 8, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 8, 2024
…rtial-results-scan-repo-sca # Conflicts: # go.sum
eranturgeman
had a problem deploying
to
frogbot
October 10, 2024 13:34 — with
GitHub Actions
Failure
eranturgeman
added
safe to test
Approve running integration tests on a pull request
new feature
Automatically generated release notes
and removed
feature request
New feature or request
labels
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
eranturgeman
had a problem deploying
to
frogbot
October 10, 2024 13:53 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
eranturgeman
had a problem deploying
to
frogbot
October 10, 2024 14:56 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
attiasas
approved these changes
Oct 10, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature that enable the user to enable partial results for Frogbot ScanRepository SCA scan.
This new feature reduces the amount of times Frogbot will fail the CI run due to a single error, and enable it to skip certain errors and to proceed scanning other parts of the project, while presenting only valid scan results and fixes according to them.
For example in a multi-project environment where we scan several working directories, and the scan have failed for some of the working directories - we will not fail the entire flow, but rather skip the scan and fixes for the failing working directory.
The enablement of this ability is available using JF_ALLOW_PARTIAL_RESULTS (bool) env var.
Related PR: jfrog/jfrog-cli-security#200