-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip-auto-install capability in Scan-Repository flow #758
Merged
eranturgeman
merged 13 commits into
jfrog:dev
from
eranturgeman:skip-auto-install-if-requested-by-user
Oct 10, 2024
Merged
Add skip-auto-install capability in Scan-Repository flow #758
eranturgeman
merged 13 commits into
jfrog:dev
from
eranturgeman:skip-auto-install-if-requested-by-user
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w env var during FrogbotDetails collection
…lue from ScanDetails to AuditParams
eranturgeman
had a problem deploying
to
frogbot
September 25, 2024 14:59 — with
GitHub Actions
Failure
eranturgeman
added
safe to test
Approve running integration tests on a pull request
new feature
Automatically generated release notes
labels
Sep 25, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 25, 2024
eranturgeman
had a problem deploying
to
frogbot
September 25, 2024 15:23 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 25, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 25, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 25, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 25, 2024
attiasas
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eranturgeman
temporarily deployed
to
frogbot
September 30, 2024 11:56 — with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
eranturgeman
had a problem deploying
to
frogbot
September 30, 2024 13:16 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
6 tasks
eranturgeman
changed the title
Add skip auto-install capability in ScanRepo and ScanPR for Yarn and NPM projects
Add skip-auto-install capability in Scan-Repository flow
Oct 10, 2024
eranturgeman
had a problem deploying
to
frogbot
October 10, 2024 10:39 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
eranturgeman
had a problem deploying
to
frogbot
October 10, 2024 13:02 — with
GitHub Actions
Failure
…-install-if-requested-by-user # Conflicts: # go.sum
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables new ability to ScanRepository flow.
This new ability allows to the user to provide a new env var: JF_SKIP_AUTO_INSTALL
This env var forces the scanning process (and hence the fixing process) to skip un-installed directories and to exclude them from SCA scans.
This ability is currently supported only for Yarn and NPM projects (and Golang since it doesn't require installation for getting the dependencies graph anyway).
Linked PRs:
jfrog/build-info-go#277
jfrog/jfrog-cli-security#191