Added centralized config resolution and utilization for Scan-PR flow #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file to scan params
…ed-config-integration
eranturgeman
added
safe to test
github-actions
bot
removed
the
safe to test
…ed-config-integration
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
…n' into centralized-config-integration
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
requested changes
Aug 29, 2024
…ed-config-integration # Conflicts: # go.mod # go.sum
…ed-config-integration # Conflicts: # go.mod
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT NOTE: This new capability is currently intended for use by JFrog internal processes ONLY! It will not be supported for customers until the official release!
This PR introduces the integration of a new config profile into the Frogbot Scan-PR flow.
Note: Currently, we only support a single-module profile with a '.' as the path_from_root. Profiles with different settings will be rejected, causing the flow to fail.
As an initial integration step, the only fields considered from the config profile, if provided, are enable_sast_scan and enable_secrets_scan. All other scan-related configurations in the profile will be ignored.
When a config profile is used for the scan, only the SAST and Secrets scanners can be activated. Other requested scanners, such as SCA, IaC, and CA, will not be executed.
If a config profile is provided, it takes priority over the jfrog-apps-config.yml file.