Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing OIDC tests #708

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Fix failing OIDC tests #708

merged 2 commits into from
Jun 5, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jun 4, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Verified OIDC tests in a fork

Screenshot 2024-06-04 at 14 03 12

@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jun 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 4, 2024
@eranturgeman eranturgeman requested a review from attiasas June 4, 2024 11:03
@eranturgeman eranturgeman mentioned this pull request Jun 4, 2024
Merged
2 tasks
@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request and removed bug Something isn't working labels Jun 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 4, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman merged commit fa91bc7 into jfrog:dev Jun 5, 2024
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @attiasas