Fix comments removal & scan-all-PRs iteration bugs #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encounter a PR we should not scan
…not return upon first PR that should not be scanned
…want to push the new comments always
eranturgeman
added
ignore for release
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
approved these changes
Mar 12, 2024
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves 2 bugs:
In scan-all-pull-requests when we iterate the open PRs and check for each of them if it should be scanned, we used to return upon the first encounter in a PR that should not be scanned. This return got removed since we want to keep iterating the rest of the PRs and check them as well
When deleting old comments we used to return if the removal failed. Therefore in this case we don't push the new comments. The removal of old comment is not mandatory and should not prevent the addition of newer comments