-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create multi scan id before running audit command #633
Merged
attiasas
merged 7 commits into
jfrog:dev
from
orz25:create-one-multi-scan-id-for-all-scans
Feb 15, 2024
Merged
Create multi scan id before running audit command #633
attiasas
merged 7 commits into
jfrog:dev
from
orz25:create-one-multi-scan-id-for-all-scans
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2024
…e-multi-scan-id-for-all-scans
attiasas
added
safe to test
Approve running integration tests on a pull request
improvement
Automatically generated release notes
labels
Feb 5, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Feb 5, 2024
orz25
changed the title
Add a call to xsc git info api before running audit
Create multi scan id before running audit command
Feb 5, 2024
attiasas
requested changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding the multiscanid for scanning Pull requests? you didn't take into account this command with your changes.
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Feb 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a call to xsc git info api before running audit in order to have one multi scan id to multiple sca scans (we send a scan request per technology and we wish to associate all the scans to one multi scan id).
PRs for client-go and cli-security:
clent-go: jfrog/jfrog-client-go#898
cli-security: jfrog/jfrog-cli-security#20