Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive golangci-linter typecheck error #589

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

eranturgeman
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Ignoring a typecheck error thrown by linter.
The first argument provided to slice.Contains cannot be inferred as []string type although it is declared correctly in another file

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 28, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 28, 2023
@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Nov 28, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 28, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 28, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 28, 2023
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@eranturgeman eranturgeman merged commit d56b152 into jfrog:dev Nov 28, 2023
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant