Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan repository - show license violation on Github security issues #575

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Scan repository - show license violation on Github security issues #575

merged 11 commits into from
Nov 16, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 14, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Additionally, a bug has been fixed where on Github issues only one run (last) was displayed as an active issues, while the other was considered resolved.

depends on: jfrog/jfrog-cli-core#1030

When watches are defined, Show license violations with default location package-descriptor at Github security issue tab

image

@attiasas attiasas added the improvement Automatically generated release notes label Nov 14, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@attiasas attiasas mentioned this pull request Nov 15, 2023
Merged
4 tasks
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@attiasas attiasas marked this pull request as ready for review November 15, 2023 09:34
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@attiasas attiasas requested a review from omerzi November 15, 2023 09:37
@attiasas attiasas requested a review from yahavi November 15, 2023 09:37
omerzi
omerzi reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@omerzi omerzi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Nov 16, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 16, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 16, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@attiasas attiasas merged commit cffaa7d into jfrog:dev Nov 16, 2023
8 of 9 checks passed
@attiasas attiasas mentioned this pull request Nov 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerzi omerzi omerzi approved these changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @omerzi