Improve readme #52
Merged
Improve readme #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yahavi
commented
Apr 24, 2022
yahavi
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Fix JF_GIT_API_ENDPOINT documentation
- gitlab -> GitLab
- _JF_USER -> JF_USER
- Reformat according to conventions
talarian1
suggested changes
Apr 24, 2022
There was a problem hiding this comment.
Should we add it to the templates as well?
What about GitHub?
[Optional, default: https://github.com]
API endpoint to GitHub
JF_GIT_API_ENDPOINT: https://github.example.com
|
@talarian1 following your comment, I created a new PR for GitHub: #53 |
eyalbe4
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.