Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JF_GIT_API_ENDPOINT Variable #51

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Add JF_GIT_API_ENDPOINT Variable #51

merged 1 commit into from
Apr 23, 2022

Conversation

0c0c0f
Copy link
Contributor

@0c0c0f 0c0c0f commented Apr 23, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@eyalbe4
Copy link
Contributor

eyalbe4 commented Apr 23, 2022

@0c0c0f,
This PR is incomplete, correct?
Is the new environment variable this PR adds to the README is actually supposed by the Frogbot code? Can you elaborate more about that?

@eyalbe4
Copy link
Contributor

eyalbe4 commented Apr 23, 2022

Oh - I know see the code does support it @0c0c0f. Thanks!
Will you be able to sign the CLA as the bot comment suggests, so that we can merge your PR?

@github-actions
Copy link
Contributor

What is Frogbot?

@0c0c0f
Copy link
Contributor Author

0c0c0f commented Apr 23, 2022

I have read the CLA Document and I hereby sign the CLA

@0c0c0f
Copy link
Contributor Author

0c0c0f commented Apr 23, 2022

Oh - I know see the code does support it @0c0c0f. Thanks! Will you be able to sign the CLA as the bot comment suggests, so that we can merge your PR?
agreed! ref: #51 (comment)

@eyalbe4 eyalbe4 merged commit c9e322c into jfrog:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0c0c0f @eyalbe4