Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitHub & Jenkins installation flow #411

Merged
merged 49 commits into from
Aug 15, 2023

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Aug 3, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

github - https://github.com/sverdlov93/frogbot/blob/Improve-docs/docs/install-github.md
jenkins - https://github.com/sverdlov93/frogbot/blob/Improve-docs/docs/templates/jenkins/README.md

@sverdlov93 sverdlov93 changed the base branch from master to dev August 3, 2023 17:31
Copy link
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Jenkins Docs, looks amazing!

# Conflicts:
#	docs/templates/github-actions/frogbot-scan-repository.yml
#	docs/templates/github-actions/scan-pull-request/frogbot-scan-pr-dotnet.yml
#	docs/templates/github-actions/scan-pull-request/frogbot-scan-pr-go.yml
#	docs/templates/github-actions/scan-pull-request/frogbot-scan-pr-gradle.yml
#	docs/templates/github-actions/scan-pull-request/frogbot-scan-pr-maven.yml
#	docs/templates/github-actions/scan-pull-request/frogbot-scan-pr-npm.yml
#	docs/templates/github-actions/scan-pull-request/frogbot-scan-pr-nuget.yml
#	docs/templates/github-actions/scan-pull-request/frogbot-scan-pr-pipenv.yml
#	docs/templates/github-actions/scan-pull-request/frogbot-scan-pr-poetry.yml
#	docs/templates/github-actions/scan-pull-request/frogbot-scan-pr-yarn.yml
@sverdlov93 sverdlov93 merged commit 9b2af94 into jfrog:dev Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants