Added GitHub security tab in createfixpullrequests #107

omerzi · 2022-07-13T12:30:17Z

All tests passed. If this feature is not already covered by the tests, I added new tests.
This pull request is on the dev branch.
I used gofmt for formatting the code before submitting the pull request.

Depends on:
jfrog/jfrog-cli-core#456
jfrog/froggit-go#45

Dev

.github/workflows/test.yml

commands/utils/utils.go

commands/createfixpullrequests.go

yahavi

Looks good🏅!
Please consider my inline comments.
Also - it looks like the changes to package.json, package-lock.json and .package-lock.json are not needed.

commands/utils/utils.go

action/node_modules/.package-lock.json

action/package.json

go.mod

commands/utils/utils.go

# Conflicts: # .github/workflows/test.yml # commands/utils/utils.go # go.mod

omerzi · 2022-07-17T12:58:02Z

Example

� Conflicts: � commands/scanpullrequest.go � go.mod � go.sum

github-actions · 2022-08-03T08:45:21Z

What is Frogbot?

…-tab

# Conflicts: # go.mod # go.sum

eyalbe4

I did go through anything yet, but I'm releasing here what I gave so far.

commands/utils/utils.go

commands/createfixpullrequests.go

� Conflicts: � go.mod � go.sum

commands/utils/utils.go

# Conflicts: # commands/utils/utils.go

eyalbe4

Let's also update the README with the new functionality and add screenshots from GitHub.

commands/createfixpullrequests.go

# Conflicts: # README.md

github-actions · 2022-08-22T07:02:40Z

What is Frogbot?

omerzi and others added 4 commits June 28, 2022 17:18

Update test.yml

863c82f

Merge remote-tracking branch 'fork/dev' into dev

1ce8079

Merge pull request #9 from jfrog/dev

6d77eb2

Dev

Added support for SARIF format as audit output

d2c64d6

omerzi had a problem deploying to frogbot July 13, 2022 12:30 Failure

omerzi requested review from yahavi, eyalbe4 and talarian1 July 14, 2022 08:43

talarian1 suggested changes Jul 14, 2022

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

commands/utils/utils.go Outdated Show resolved Hide resolved

commands/createfixpullrequests.go Outdated Show resolved Hide resolved

yahavi requested changes Jul 15, 2022

View reviewed changes

omerzi added 2 commits July 17, 2022 10:34

Added support for SARIF format as audit output

ee978a4

Merge remote-tracking branch 'fork/security-tab' into security-tab

43c9ef2

# Conflicts: # .github/workflows/test.yml # commands/utils/utils.go # go.mod

omerzi had a problem deploying to frogbot July 17, 2022 07:36 Failure

omerzi added 2 commits July 17, 2022 10:41

Merge remote-tracking branch 'fork/security-tab' into security-tab

4ab1cd1

# Conflicts: # .github/workflows/test.yml # commands/utils/utils.go # go.mod

Merge remote-tracking branch 'fork/security-tab' into security-tab

a2e4627

omerzi had a problem deploying to frogbot July 17, 2022 07:41 Failure

omerzi added 2 commits July 17, 2022 10:45

Merge remote-tracking branch 'fork/security-tab' into security-tab

b4ce434

Merge remote-tracking branch 'fork/security-tab' into security-tab

dcaa944

omerzi had a problem deploying to frogbot July 17, 2022 07:45 Failure

Merge remote-tracking branch 'fork/security-tab' into security-tab

9733180

omerzi had a problem deploying to frogbot July 17, 2022 07:46 Failure

Update package.json

90ccf7a

omerzi had a problem deploying to frogbot July 17, 2022 07:57 Failure

omerzi added 2 commits July 17, 2022 11:14

Merge remote-tracking branch 'fork/security-tab' into security-tab

3c66b8c

Merge remote-tracking branch 'fork/security-tab' into security-tab

04ca4e3

omerzi had a problem deploying to frogbot July 17, 2022 08:14 Failure

omerzi and others added 2 commits July 25, 2022 14:48

Update createfixpullrequests_test.go

b4504fb

Merge branch 'dev' of https://github.com/jfrog/frogbot into security-tab

05ab091

omerzi changed the title ~~Added GitHub securirty tab in createfixpullrequests~~ Added GitHub security tab in createfixpullrequests Jul 26, 2022

omerzi added the new feature Automatically generated release notes label Jul 26, 2022

Merge branch 'dev' of https://github.com/jfrog/frogbot into security-tab

bcf4ef5

� Conflicts: � commands/scanpullrequest.go � go.mod � go.sum

omerzi temporarily deployed to frogbot August 2, 2022 11:45 Inactive

Merge branch 'dev' of https://github.com/jfrog/frogbot into security-tab

4e12321

omerzi added 2 commits August 3, 2022 16:55

Merge branch 'dev' of https://github.com/omerzi/frogbot into security…

8c02893

…-tab

Merge remote-tracking branch 'fork/security-tab' into security-tab

76a4641

# Conflicts: # go.mod # go.sum

eyalbe4 requested changes Aug 15, 2022

View reviewed changes

commands/utils/utils.go Show resolved Hide resolved

commands/createfixpullrequests.go Outdated Show resolved Hide resolved

omerzi added 2 commits August 17, 2022 11:30

Merge branch 'dev' of https://github.com/jfrog/frogbot into security-tab

17ee470

� Conflicts: � go.mod � go.sum

Code review changes

9216152

omerzi had a problem deploying to frogbot August 17, 2022 08:42 Failure

omerzi requested a review from eyalbe4 August 17, 2022 08:42

Code review changes

1dafcd6

omerzi had a problem deploying to frogbot August 17, 2022 08:48 Failure

yahavi reviewed Aug 17, 2022

View reviewed changes

commands/utils/utils.go Outdated Show resolved Hide resolved

omerzi added 2 commits August 17, 2022 15:22

Code review changes

fd59886

Merge remote-tracking branch 'fork/security-tab' into security-tab

e76f530

# Conflicts: # commands/utils/utils.go

omerzi had a problem deploying to frogbot August 17, 2022 12:24 Failure

eyalbe4 requested changes Aug 22, 2022

View reviewed changes

commands/createfixpullrequests.go Outdated Show resolved Hide resolved

commands/createfixpullrequests.go Outdated Show resolved Hide resolved

eyalbe4 mentioned this pull request Aug 22, 2022

Added pip, pipenv, yarn support to Frogbot PR fix #113

Merged

3 tasks

Merge branch 'dev' of https://github.com/jfrog/frogbot into security-tab

c479882

omerzi had a problem deploying to frogbot August 22, 2022 06:42 Failure

omerzi requested a review from eyalbe4 August 22, 2022 06:42

omerzi added 2 commits August 22, 2022 09:57

Merge branch 'dev' of https://github.com/jfrog/frogbot into security-tab

989501b

Merge remote-tracking branch 'fork/security-tab' into security-tab

fdf065b

# Conflicts: # README.md

omerzi temporarily deployed to frogbot August 22, 2022 07:00 Inactive

omerzi merged commit 2d3b55c into jfrog:dev Aug 22, 2022

omerzi deleted the security-tab branch February 22, 2023 11:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added GitHub security tab in createfixpullrequests #107

Added GitHub security tab in createfixpullrequests #107

omerzi commented Jul 13, 2022 •

edited

Loading

yahavi left a comment

omerzi commented Jul 17, 2022 •

edited

Loading

github-actions bot commented Aug 3, 2022

eyalbe4 left a comment

eyalbe4 left a comment

github-actions bot commented Aug 22, 2022

Added GitHub security tab in createfixpullrequests #107

Added GitHub security tab in createfixpullrequests #107

Conversation

omerzi commented Jul 13, 2022 • edited Loading

yahavi left a comment

Choose a reason for hiding this comment

omerzi commented Jul 17, 2022 • edited Loading

github-actions bot commented Aug 3, 2022

eyalbe4 left a comment

Choose a reason for hiding this comment

eyalbe4 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 22, 2022

omerzi commented Jul 13, 2022 •

edited

Loading

omerzi commented Jul 17, 2022 •

edited

Loading