(pkg/openapi3) Support schema in openapi3 format #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 82.14% 82.15% +0.01%
==========================================
Files 125 132 +7
Lines 5483 5907 +424
==========================================
+ Hits 4504 4853 +349
- Misses 664 723 +59
- Partials 315 331 +16
|
azzz
force-pushed
the
feat/openapi-schemas-support
branch
from
fbad000 to
8be015b
Compare
azzz
changed the title
azzz
force-pushed
the
feat/openapi-schemas-support
branch
2 times, most recently
from
83a230c to
d0cfa0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 82.70% 82.23% -0.47%
==========================================
Files 141 144 +3
Lines 6204 6385 +181
==========================================
+ Hits 5131 5251 +120
- Misses 725 761 +36
- Partials 348 373 +25
|
jeroenrinzema
requested changes
Oct 13, 2020
pkg/providers/openapi3/schema.go
Outdated
Comment on lines
119
to
141
| func scalar(s *openapi.Schema) (specs.Template, error) { | ||
| var t types.Type | ||
|
|
||
| switch s.Type { | ||
| case "string": | ||
| t = types.String | ||
| case "boolean": | ||
| t = types.Bool | ||
| case "number": | ||
| t = types.Float | ||
| case "integer": | ||
| t = types.Int32 | ||
| default: | ||
| return specs.Template{}, fmt.Errorf("unknown type %s", s.Type) | ||
| } | ||
|
|
||
| return specs.Template{ | ||
| Scalar: &specs.Scalar{Type: t}, | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
We could easily add add support default types fetched from openapi.Schema.
default - The default value represents what would be assumed by the consumer of the input as the value of the schema if one is not provided. Unlike JSON Schema, the value MUST conform to the defined type for the Schema Object defined at the same level. For example, if type is string, then default can be "foo" but cannot be 1.
There was a problem hiding this comment.
I supported default for scalar types.
There was a problem hiding this comment.
*I just supported, pls take a look at the commit.
azzz
force-pushed
the
feat/openapi-schemas-support
branch
from
f3aad11 to
dc2d7d7
Compare
azzz
force-pushed
the
feat/openapi-schemas-support
branch
from
dc2d7d7 to
f484121
Compare
jeroenrinzema
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for OpenAPI3 schema specifications. OpenAPI3 services/endpoints are not included due to OpenAPI3 implementation.